refactor(agent): drop pass-through methods, free functions are the surface #1

Merged

mathew merged 2 commits from agent-drop-thunks into main

2026-06-03 17:24:16 +00:00

mathew commented

2026-06-03 17:10:26 +00:00

Owner

The agent/ composition root claimed in its module docstring that "the actual work lives in focused submodules," but the Agent class still carried ten pass-through methods (_heartbeat_loop, _dispatch, _handle_garage_refresh, etc.) that only forwarded to those submodules.

Production code already called the free functions directly; the thunks survived as a test-compat shim left over from the earlier agent.py → agent/ refactor. This commit finishes the job: the ten thunks are gone, Agent is now __init__ + run(), and ~25 test call sites switched to calling loops.heartbeat_loop(agent, ws), dispatch.dispatch_message(agent, ws, raw), etc. directly.

While renaming, twelve instance attrs lost their leading underscore (config, registry, garage_state, ...) since the submodules read them across module boundaries by design; the three cryptographic attrs (_secret, _nonce_store, _ssl_ctx) keep their underscore as a deliberate sigil meaning "handle with care."

Net -41 lines, 1128/1128 tests pass, fitness and import-linter green.

The agent/ composition root claimed in its module docstring that "the actual work lives in focused submodules," but the Agent class still carried ten pass-through methods (`_heartbeat_loop`, `_dispatch`, `_handle_garage_refresh`, etc.) that only forwarded to those submodules. Production code already called the free functions directly; the thunks survived as a test-compat shim left over from the earlier agent.py → agent/ refactor. This commit finishes the job: the ten thunks are gone, Agent is now `__init__` + `run()`, and ~25 test call sites switched to calling `loops.heartbeat_loop(agent, ws)`, `dispatch.dispatch_message(agent, ws, raw)`, etc. directly. While renaming, twelve instance attrs lost their leading underscore (`config`, `registry`, `garage_state`, ...) since the submodules read them across module boundaries by design; the three cryptographic attrs (`_secret`, `_nonce_store`, `_ssl_ctx`) keep their underscore as a deliberate sigil meaning "handle with care." Net -41 lines, 1128/1128 tests pass, fitness and import-linter green.

mathew added 1 commit

2026-06-03 17:10:27 +00:00